-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "fix: redirect to proper place after upgrade" #46460
Conversation
@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Straight revert, gonna merge without the checklist |
@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
See above |
Revert "fix: redirect to proper place after upgrade" (cherry picked from commit 82fcf30)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.0.14-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
Reverts #45730
Created this revert because #45730 caused this deploy blocker: #46450
and the animation looks broken: #45730 (comment)